Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][RestAPI] Support submit job with seatunnel style hocon format config #8000

Merged
merged 34 commits into from
Nov 23, 2024

Conversation

CosmosNi
Copy link
Contributor

@CosmosNi CosmosNi commented Nov 8, 2024

#7925

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@Hisoka-X
Copy link
Member

Hisoka-X commented Nov 8, 2024

cc @liugddx

@Hisoka-X Hisoka-X linked an issue Nov 8, 2024 that may be closed by this pull request
3 tasks
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs. Thanks @CosmosNi !

@liunaijie
Copy link
Member

I see this pr is put the config string to request body.
Do we conside using multipart/form-data upload the file into a config_file (or other name) parameter

@Hisoka-X
Copy link
Member

Do we conside using multipart/form-data upload the file into a config_file (or other name) parameter

Ok for me, but I think this should be another feature. Please create an issue for this.

@liunaijie
Copy link
Member

Do we conside using multipart/form-data upload the file into a config_file (or other name) parameter

Ok for me, but I think this should be another feature. Please create an issue for this.

Yes, it should be in another pr, just point it in this issue.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CosmosNi ! Please update the doc too.

@github-actions github-actions bot removed the e2e label Nov 14, 2024
@github-actions github-actions bot added the e2e label Nov 15, 2024
@CosmosNi
Copy link
Contributor Author

@Hisoka-X @liugddx PTAL,thanks

@CosmosNi CosmosNi requested a review from Hisoka-X November 21, 2024 01:06
Hisoka-X
Hisoka-X previously approved these changes Nov 21, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes. Thanks @CosmosNi ! cc @liugddx

@hailin0 hailin0 merged commit f855cdd into apache:dev Nov 23, 2024
5 checks passed
@liugddx
Copy link
Member

liugddx commented Nov 23, 2024

LGTM Thanks @CosmosNi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][RestAPI] Support submit job with seatunnel style hocon format config
5 participants