-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Connector-V2] Support read archive compress file #7633
Merged
wuchunfu
merged 11 commits into
apache:dev
from
corgy-w:support-read-archive-compress-file
Sep 20, 2024
Merged
[Improve][Connector-V2] Support read archive compress file #7633
wuchunfu
merged 11 commits into
apache:dev
from
corgy-w:support-read-archive-compress-file
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
901a573
to
8e0e189
Compare
wuchunfu
reviewed
Sep 12, 2024
Hisoka-X
reviewed
Sep 13, 2024
Hisoka-X
reviewed
Sep 14, 2024
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseFileSinkConfig.java
Outdated
Show resolved
Hide resolved
3015a28
to
d2e2516
Compare
Hisoka-X
reviewed
Sep 18, 2024
...base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSinkConfig.java
Show resolved
Hide resolved
Hisoka-X
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @corgy-w !
PTAL @wuchunfu |
wuchunfu
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @corgy-w thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
#7587
Temporary support Support for compressed files when reading
zip、tar
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.