Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][API] Add IGNORE savemode type #7443

Merged
merged 6 commits into from
Aug 22, 2024
Merged

[Improve][API] Add IGNORE savemode type #7443

merged 6 commits into from
Aug 22, 2024

Conversation

jw-itq
Copy link
Contributor

@jw-itq jw-itq commented Aug 21, 2024

Fix #7430

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@jw-itq jw-itq closed this Aug 21, 2024
@jw-itq jw-itq reopened this Aug 21, 2024
@Hisoka-X Hisoka-X changed the title [Fix] [sink elasticsearch] Fix the issue of sink-es saveMode and es automatic index creation conflict #7430 [Improve][API] Add IGNORE savemode type Aug 21, 2024
Comment on lines 37 to 38
// Ignore
IGNORE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataSaveMode doesn't need IGNORE. The behavior of IGNORE same as APPEND_DATA.

Copy link
Contributor Author

@jw-itq jw-itq Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataSaveMode doesn't need IGNORE. The behavior of IGNORE same as APPEND_DATA.

ok, thanks. I want to try again

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update doc.
image

@jw-itq
Copy link
Contributor Author

jw-itq commented Aug 22, 2024

Please update doc. image

ok, thanks.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes. Thanks @jw-itq

@hailin0 hailin0 merged commit 825caa8 into apache:dev Aug 22, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants