Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Rabbitmq] Allow configuration of queue durability and deletion policy #7365

Merged
merged 11 commits into from
Aug 29, 2024
Merged

[Feature][Rabbitmq] Allow configuration of queue durability and deletion policy #7365

merged 11 commits into from
Aug 29, 2024

Conversation

zqr10159
Copy link
Member

@zqr10159 zqr10159 commented Aug 10, 2024 •
edited
Loading

Queue settings in Rabbitmq connector are now configurable to specify durable,exclusive, and auto-delete options. This enables users to define queue behavior

Check list

@zqr10159
feat(rabbitmq): allow configuration of queue durability and deletion …
2b96a68 
…policy

Queue settings in RabbitMQ connector are now configurable to specify durable,exclusive, and auto-delete options. This enables users to define queue behavior
based on their processing requirements.
@zqr10159
docs(rabbitmq-sink): add durable, exclusive, and auto_delete config o…
46773bc 
…ptions

Add descriptions for new configuration options 'durable', 'exclusive', and
'auto_delete' in the RabbitMQ sink documentation. These options allow for
greater control over queue behavior, enabling users to configure queue
durability, exclusivity, and automatic deletion under certain conditions.
@zqr10159
Merge remote-tracking branch 'origin/dev' into dev
e019da4
@zqr10159 zqr10159 mentioned this pull request Aug 10, 2024
Closed
3 tasks
@Hisoka-X Hisoka-X linked an issue Aug 10, 2024 that may be closed by this pull request
[Feature][Rabbitmq] Allow configuration of queue durability and deletion policy #7363
Closed
3 tasks
@zqr10159
style(rabbitmq-connector): reformat queue declare method for better r…
cf17c66 
…eadability

Reformat the `declareQueueDefaults` method in `RabbitmqClient.java` to enhance
code readability. Adjust the line breaks to adhere to the project's codingstandards. Update the commit message to include a full stop for consistency.

BREAKING CHANGE: No functionality changes; purely cosmetic adjustments to the
code formatting.
@zqr10159
docs(rabbitmq-sink): add example with durable queue settings
f1ae254 
Add a second example in the Rabbitmq sink documentation, illustrating the
configuration of a durable queue with exclusive and auto-delete properties.
@Hisoka-X
Copy link
Member

Thanks @zqr10159 for contribute this! Could you add a test case in

seatunnel/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-rabbitmq-e2e/src/test/java/org/apache/seatunnel/e2e/connector/rabbitmq/RabbitmqIT.java

Line 4 in 862e205

* this work for additional information regarding copyright ownership.
?

@zqr10159
Copy link
Member Author

Thanks @zqr10159 for contribute this! Could you add a test case in

seatunnel/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-rabbitmq-e2e/src/test/java/org/apache/seatunnel/e2e/connector/rabbitmq/RabbitmqIT.java

Line 4 in 862e205

* this work for additional information regarding copyright ownership.
?

Ok，I will add it later.

@zqr10159
Merge branch 'apache:dev' into dev
39ee7c5
@zqr10159
feat(rabbitmq): allow configuring queue properties
cf86304 
Expose configuration options for setting queue durability, exclusivity, and auto-deletion in RabbitMQ connector. These settings are now adjustable through the connector's configuration, enabling users to optimize queue behavior according to their specific use cases and requirements.
@github-actions github-actions bot added the e2e label Aug 12, 2024
@zqr10159
Copy link
Member Author

@Hisoka-X Done!

@Hisoka-X
Copy link
Member

please fix ci

@zqr10159
Copy link
Member Author

Sorry, I don't know how to fix this. I created a new branch and rolled back all my code, but still the local test doesn't pass, can you give me some guidance, thank you very much!
image

@Hisoka-X
Copy link
Member

Sorry, I don't know how to fix this. I created a new branch and rolled back all my code, but still the local test doesn't pass, can you give me some guidance, thank you very much! image

Have you try build package (eg: mvn clean package -DskipTests) before execute e2e test case?

@Carl-Zhou-CN
Copy link
Member

Sorry, I don't know how to fix this. I created a new branch and rolled back all my code, but still the local test doesn't pass, can you give me some guidance, thank you very much! image

In my opinion, you should be the window system, which is due to the package not copy to the container, or the script newline problem, you modify the idea newline environment

@zqr10159
Copy link
Member Author

Sorry, I don't know how to fix this. I created a new branch and rolled back all my code, but still the local test doesn't pass, can you give me some guidance, thank you very much! image

In my opinion, you should be the window system, which is due to the package not copy to the container, or the script newline problem, you modify the idea newline environment

Thanks,I'll try it

@Hisoka-X
Copy link
Member

Could you retry the failed ci? Thanks.

@zqr10159
Copy link
Member Author

Could you retry the failed ci? Thanks.

The previous local test was a Windows line break issue, the local modification has passed the test, but the github ci seems to have a different error.

@Hisoka-X
Copy link
Member

Please merge from dev to retrigger it.

@Hisoka-X Hisoka-X added this to the 2.3.8 milestone Aug 27, 2024
@zqr10159
Copy link
Member Author

@Hisoka-X All done， Thanks!

Hisoka-X
Hisoka-X approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @zqr10159 !

@hailin0 hailin0 merged commit aabfc8e into apache:dev Aug 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 document e2e rabbitmq reviewed
Projects
None yet
Milestone
2.3.8
Development

Successfully merging this pull request may close these issues.

[Feature][Rabbitmq] Allow configuration of queue durability and deletion policy
4 participants
@zqr10159 @Hisoka-X @Carl-Zhou-CN @hailin0