-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve] Make ClickhouseFileSinker support tables containing materialized columns #6956
Conversation
…erialized columns by ignoring the materialized columns in the CK table when building the temporary table. In this way, when generating the ck part file, the file corresponding to the materialized column will be automatically generated, otherwise an error will be reported when generating the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, according to the community principles, can you provide a screenshot of the successful operation after the change?
Of course, this is necessary, but my company has very strict regulations on data display, so I don't show the imported data, the following are two figures, one is about the table creation statement of the materialized column, and the second is the SQL that queries the materialized column is not null after importing, you can see that the data of the materialized column has been generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @ddna1021
…lized columns (apache#6956) * [Improvement] Make ClickhouseFileSinker support tables containing materialized columns by ignoring the materialized columns in the CK table when building the temporary table. In this way, when generating the ck part file, the file corresponding to the materialized column will be automatically generated, otherwise an error will be reported when generating the file. * Make ClickhouseFileSinker support tables containing materialized columns --------- Co-authored-by: fandonglai <[email protected]>
Make ClickhouseFileSinker supports tables containing materialized columns by ignoring the materialized columns in the CK table when extracting the temporary table schema. In this way, when generating the ck part file, the file corresponding to the materialized column will be automatically generated, otherwise an error will be reported when generating the file.
Already tested