Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Make ClickhouseFileSinker support tables containing materialized columns #6956

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

ddna1021
Copy link
Contributor

@ddna1021 ddna1021 commented Jun 6, 2024

Make ClickhouseFileSinker supports tables containing materialized columns by ignoring the materialized columns in the CK table when extracting the temporary table schema. In this way, when generating the ck part file, the file corresponding to the materialized column will be automatically generated, otherwise an error will be reported when generating the file.

Already tested

fandonglai added 2 commits June 6, 2024 15:00
…erialized columns by ignoring the materialized columns in the CK table when building the temporary table. In this way, when generating the ck part file, the file corresponding to the materialized column will be automatically generated, otherwise an error will be reported when generating the file.
@ddna1021 ddna1021 changed the title [Improvement] Make ClickhouseFileSinker support tables containing materialized columns [Improve] Make ClickhouseFileSinker support tables containing materialized columns Jun 6, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, according to the community principles, can you provide a screenshot of the successful operation after the change?

@ddna1021
Copy link
Contributor Author

ddna1021 commented Jun 7, 2024

LGTM. However, according to the community principles, can you provide a screenshot of the successful operation after the change?

Of course, this is necessary, but my company has very strict regulations on data display, so I don't show the imported data, the following are two figures, one is about the table creation statement of the materialized column, and the second is the SQL that queries the materialized column is not null after importing, you can see that the data of the materialized column has been generated.

image

image

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ddna1021

@hailin0 hailin0 merged commit 87c6adc into apache:dev Jun 7, 2024
5 checks passed
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
…lized columns (apache#6956)

* [Improvement] Make ClickhouseFileSinker support tables containing materialized columns by ignoring the materialized columns in the CK table when building the temporary table. In this way, when generating the ck part file, the file corresponding to the materialized column will be automatically generated, otherwise an error will be reported when generating the file.

* Make ClickhouseFileSinker support tables containing materialized columns

---------

Co-authored-by: fandonglai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants