[Improve][Transform] Remove Fallback during parsing Transform process #6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Hisoka-X |
Hisoka-X
reviewed
Apr 7, 2024
| @@ -476,8 +453,10 @@ public static SeaTunnelDataType<?> getProducedType(Action action) { | |||
| .getProducedCatalogTable() | |||
| .getSeaTunnelRowType(); | |||
| } catch (UnsupportedOperationException e) { | |||
There was a problem hiding this comment.
I think it should not throw UnsupportedOperationException after this change.
Suggested change
| } catch (UnsupportedOperationException e) { |
There was a problem hiding this comment.
I think it should not throw
UnsupportedOperationExceptionafter this change.
done.
Hisoka-X
approved these changes
Apr 7, 2024
hailin0
approved these changes
Apr 7, 2024
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Currently all Transform initialization can be done through TransFormFactory, so we can remove fallback code and deprecated SeaTunnelPluginLifeCycle interface.
Does this PR introduce any user-facing change?
no
How was this patch tested?
exist tests.
Check list
New License Guide
release-note.