[Fix][StarRocks] Fix NPE when upstream catalogtable table path only have table name part

[liunaijie]

Purpose of this pull request

close #6524
in some source connector, it not set db name, so will get NPE here

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

• If any new Jar binary package adding in your PR, please add License Notice according
  New License Guide
• If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
• If you are contributing the connector code, please check that the following files are updated:
  1. Update change log that in connector document. For more details you can refer to connector-v2
  2. Update plugin-mapping.properties and add new connector information in it
  3. Update the pom file of seatunnel-dist
• Update the release-note.

[Hisoka-X]

Could you add a test case for this?

[liunaijie]

Could you add a test case for this?

@Hisoka-X in the current code, there has the NPE check https://github.com/apache/seatunnel/pull/6540/files#diff-ab5c2b43dd112473304501aa777993ab9cd746f3a12b6606f87523d92b5e9086R117. In this method i think the author is missing to check.

[Hisoka-X]

Since this is a bug, then we could have the means to reproduce it. It is best to use test cases to reproduce the bug, so as to ensure that there will be no regression in the future.

[Hisoka-X]

Thanks @liunaijie for update test case! I suggest use fake source connector to produce table with only table name. There are example https://github.com/apache/seatunnel/blob/cdfb5735acfbd281e01bf34393870fa573c5516c/docs/en/concept/schema-feature.md#table. It will be more simple and stable.

[Hisoka-X]

[Hisoka-X]

I prefer when source database name is null, we can treat it as empty string.

Suggested change

	if (StringUtils.isNotBlank(sourceDatabaseName)) {
	sinkDatabaseName =
	sinkDatabaseName.replace(REPLACE_DATABASE_NAME_KEY, sourceDatabaseName);
	}
	sinkDatabaseName = sinkDatabaseName.replace(REPLACE_DATABASE_NAME_KEY, sourceDatabaseName != null ? sourceDatabaseName: "");

[liunaijie]

Done

[Hisoka-X]

Could you remind check other connector like doris/jdbc/file/s3 too (open another pr is fine)? Thanks

[liunaijie]

Could you remind check other connector like doris/jdbc/file/s3 too (open another pr is fine)? Thanks

ok, i will check other connectors. it will in another pr to fix if also has issue.

[Hisoka-X]

Please fix ci

[Hisoka-X]

LGTM if ci passed.

[liunaijie]

Could you remind check other connector like doris/jdbc/file/s3 too (open another pr is fine)? Thanks

I checked other connectors, they all have null value check.
But when i check the code, i find StarRocksCDCSinkIT is disabled, the disable reason is has some issue unfixed @Hisoka-X

[Hisoka-X]

Could you remind check other connector like doris/jdbc/file/s3 too (open another pr is fine)? Thanks

I checked other connectors, they all have null value check. But when i check the code, i find StarRocksCDCSinkIT is disabled, the disable reason is has some issue unfixed @Hisoka-X

Yes, could you try to reopen it?