Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix][file-execl] Fix The Row duplicate case by SeaTunnelRow multiplexing #5932

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

ic4y
Copy link
Contributor

@ic4y ic4y commented Nov 28, 2023

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case

@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Nov 30, 2023
@EricJoy2048 EricJoy2048 changed the title [bugfix][file-execl] Fix the Issue of Abnormal Data Reading from Excel Files [bugfix][file-execl] Fix The Row duplicate case by SeaTunnelRow multiplexing Jan 8, 2024
@EricJoy2048
Copy link
Member

Please add test case

Please add test case

Please add test case

I think you can use a localfile sink to check the data read from excel.

@EricJoy2048
Copy link
Member

#6159 test issue created.

@hailin0
Copy link
Member

hailin0 commented Jan 8, 2024

#6159 test issue created.

ok
Please add test cases later

@EricJoy2048 EricJoy2048 merged commit 6a2b05a into apache:dev Jan 8, 2024
2 checks passed
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants