[Fix] Fix ConnectorPackageServiceContainer miss implement getSavePointCommand/getRestoreCommand
#5780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…intCommand/getRestoreCommand
liunaijie
reviewed
Nov 3, 2023
| @@ -61,6 +63,7 @@ void beforeClass() throws Exception { | |||
| SeaTunnelConfig seaTunnelConfig = ConfigProvider.locateAndGetSeaTunnelConfig(); | |||
| seaTunnelConfig.getHazelcastConfig().setClusterName(testClusterName); | |||
| hazelcastInstance = SeaTunnelServerStarter.createHazelcastInstance(seaTunnelConfig); | |||
| Common.setDeployMode(DeployMode.CLIENT); | |||
There was a problem hiding this comment.
Actually you don't need set the deployMode, because it will auto set to CLIENT if the deployMode is null.
There was a problem hiding this comment.
But without this, the test case will failed now. Could you investigate it?
There was a problem hiding this comment.
These are failed action. https://github.com/Hisoka-X/seatunnel-fork/actions/runs/6741940408/job/18327335813
There was a problem hiding this comment.
I am not clear if this is caused by we have some UT case set the DeployMode but doesn't clear this after the ut finished.
There was a problem hiding this comment.
Let's merge this first. If @liunaijie have better idea for RestApiIT. You can create a PR for it.
4 tasks
hailin0
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR fix
ConnectorPackageServiceContainermiss implement getSavePointCommand/getRestoreCommand. The build will failed.Does this PR introduce any user-facing change?
no
How was this patch tested?
exist test.
Check list
New License Guide
release-note.