Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Refactor Spark/Flink execution processor #5595

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Oct 7, 2023

Purpose of this pull request

This PR refactor Spark/Flink execution processor, so that Spark/Flink can use new TableSource(Sink)Factory to create Source(Sink). Also let Spark/Flink execution processor use CatalogTable as new schema info to transform to transform and sink connector.

Does this PR introduce any user-facing change?

No

How was this patch tested?

exist test.

Check list

@Hisoka-X
Copy link
Member Author

Hisoka-X commented Oct 8, 2023

cc @TyrantLucifer @hailin0 @ruanwenjun

@hailin0
Copy link
Member

hailin0 commented Oct 11, 2023

Waitting for ci to pass

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricJoy2048 EricJoy2048 merged commit f083a86 into apache:dev Oct 16, 2023
@Hisoka-X Hisoka-X deleted the refactor-flink-and-spark branch October 16, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants