-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hotfix][connector-v2][clickhouse] Fixed an out-of-order BUG with output data fields of clickhouse-sink #5346
[Hotfix][connector-v2][clickhouse] Fixed an out-of-order BUG with output data fields of clickhouse-sink #5346
Conversation
…put data fields of clickhouse-sink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM . @Hisoka-X PTAL
Please fix CI error. Run |
Fixed, please check it |
Could you add a test case for this bug fixed? To make sure this bug will not regression. |
create sql create table test(
`field1` String,
`field2` String,
`field3` String,
`field4` String
)engine=Memory; config file
|
@wowzx Could you add UT for this? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aggre
Does anyone want to help add testcase? |
…put data fields of clickhouse-sink (apache#5346)
If the order of the output data fields is not in accordance with the order of the table_schema fields, the output fields are out of order.
This is caused by the array of fields returned with
JdbcBatchStatementExecutorBuilder#getDefaultProjectionFields
being sorted in table_schema field orderSee: #5176
Purpose of this pull request
Check list
New License Guide
release-note
.