-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][shade][Jackson] Add seatunnel-jackson module #3947
Conversation
945bbab
to
602e794
Compare
c02dfc6
to
d08e122
Compare
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/OptionRule.java
Outdated
Show resolved
Hide resolved
d08e122
to
cfe9e58
Compare
@EricJoy2048 @ashulin PTAL. |
should we put all shade jars in this? github.com/apache/incubator-seatunnel-shade @EricJoy2048 |
Yup, all shade dependencies shoule be moved to this repository. But before the shade repository released, main repository can not add shade dependency in pom file. In oreder to not block the progress of support check logic, so I temporary add it in main repository. |
waiting for the first release. |
@@ -50,6 +50,7 @@ protostuff-runtime-1.8.0.jar | |||
scala-library-2.11.12.jar | |||
seatunnel-config-base-2.1.1.jar | |||
seatunnel-config-shade-2.1.1.jar | |||
seatunnel-jackson-2.3.1-SNAPSHOT-optional.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't add this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we didn't add this,CI will not be passed. Do you have any good advice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will take a look later:)
Purpose of this pull request
close #3936
Check list
New License Guide
release-note
.