Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][shade][Jackson] Add seatunnel-jackson module #3947

Merged
merged 8 commits into from
Jan 17, 2023

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

close #3936

Check list

@TyrantLucifer TyrantLucifer marked this pull request as ready for review January 14, 2023 14:30
@TyrantLucifer TyrantLucifer changed the title [Feature][shade][Jackson] Add seatunnel-seatunnel module [Feature][shade][Jackson] Add seatunnel-jackson module Jan 14, 2023
EricJoy2048
EricJoy2048 previously approved these changes Jan 16, 2023
@TyrantLucifer
Copy link
Member Author

@EricJoy2048 @ashulin PTAL.

@CalvinKirs
Copy link
Member

should we put all shade jars in this? github.com/apache/incubator-seatunnel-shade @EricJoy2048

@TyrantLucifer
Copy link
Member Author

should we put all shade jars in this? github.com/apache/incubator-seatunnel-shade @EricJoy2048

Yup, all shade dependencies shoule be moved to this repository. But before the shade repository released, main repository can not add shade dependency in pom file. In oreder to not block the progress of support check logic, so I temporary add it in main repository.

@CalvinKirs
Copy link
Member

should we put all shade jars in this? github.com/apache/incubator-seatunnel-shade @EricJoy2048

waiting for the first release.

@@ -50,6 +50,7 @@ protostuff-runtime-1.8.0.jar
scala-library-2.11.12.jar
seatunnel-config-base-2.1.1.jar
seatunnel-config-shade-2.1.1.jar
seatunnel-jackson-2.3.1-SNAPSHOT-optional.jar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't add this line

Copy link
Member Author

@TyrantLucifer TyrantLucifer Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we didn't add this,CI will not be passed. Do you have any good advice?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will take a look later:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][shade][jackson] Add jackson module
5 participants