Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Code-Style] Add the spotless plugin for unified code style. #3939

Merged
merged 1 commit into from
Feb 10, 2023
Merged

[Improve][Code-Style] Add the spotless plugin for unified code style. #3939

merged 1 commit into from
Feb 10, 2023

Conversation

FlechazoW
Copy link
Contributor

Purpose of this pull request

close #2492.

Check list

@FlechazoW FlechazoW mentioned this pull request Jan 14, 2023
Closed
@FlechazoW
Copy link
Contributor Author

@EricGao888 @TyrantLucifer PTAL. Thanks.

@Hisoka-X Hisoka-X requested review from CalvinKirs, TyrantLucifer and EricJoy2048 and removed request for TyrantLucifer January 30, 2023 08:14
@zhuangchong
Copy link
Contributor

Are spotless and checkstyle complementary? Has this been discussed?

@FlechazoW
Copy link
Contributor Author

Are spotless and checkstyle complementary? Has this been discussed?

This has been discussed, see #3942 . Spotless and checkstyle are two different code styles. In order to maintain a unified style, we decided to use spotless and remove checkstyle.

@FlechazoW
Copy link
Contributor Author

PTAL. @EricJoy2048 @CalvinKirs @EricGao888

@FlechazoW FlechazoW force-pushed the feat_add_spotless branch 2 times, most recently from 0678432 to 6a57cb8 Compare February 7, 2023 09:19
ruanwenjun
ruanwenjun reviewed Feb 7, 2023
View reviewed changes
@FlechazoW FlechazoW force-pushed the feat_add_spotless branch 2 times, most recently from 7041669 to fa4c2b7 Compare February 8, 2023 09:58
@ruanwenjun
Copy link
Member

LGTM, you need to skip the spotless check in ci action, if you don't want to format the whole project in this PR.

@hailin0
Copy link
Member

hailin0 commented Feb 10, 2023

LGTM

@Hisoka-X Hisoka-X mentioned this pull request Feb 10, 2023
Closed
4 tasks
@TyrantLucifer TyrantLucifer merged commit 290c4a4 into apache:dev Feb 10, 2023
@FlechazoW FlechazoW deleted the feat_add_spotless branch February 15, 2023 01:32
ashulin pushed a commit to ashulin/incubator-seatunnel that referenced this pull request Feb 28, 2023
@FlechazoW @ashulin
[Improve][Core] Add the spotless plugin for unified code style. (apac…
172aac9 
…he#3939)

# Conflicts:
#	.github/workflows/backend.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruanwenjun ruanwenjun ruanwenjun left review comments

@zhuangchong zhuangchong zhuangchong requested changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

@EricJoy2048 EricJoy2048 Awaiting requested review from EricJoy2048

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Style] Use Spotless to fix formatting and style errors automatically
6 participants
@FlechazoW @zhuangchong @ruanwenjun @hailin0 @CalvinKirs @TyrantLucifer