Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][Connectors] Text And Json WriteStrategy lost the sinkColumnsIndexInRow #3863

Merged
merged 2 commits into from
Jan 18, 2023
Merged

[Bug][Connectors] Text And Json WriteStrategy lost the sinkColumnsIndexInRow #3863

merged 2 commits into from
Jan 18, 2023

Conversation

lvshaokang
Copy link
Contributor

Purpose of this pull request

refer #3815

Fix text and json write strategy lost the sinkColumnsIndexInRow

Check list

TaoZex
TaoZex previously approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hailin0
Copy link
Member

hailin0 commented Jan 5, 2023

@TyrantLucifer

@github-actions github-actions bot removed the reviewed label Jan 5, 2023
@EricJoy2048
Copy link
Member

@TyrantLucifer PTAL

EricJoy2048
EricJoy2048 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EricJoy2048 EricJoy2048 merged commit 7b5f6f1 into apache:dev Jan 18, 2023
@TyrantLucifer TyrantLucifer mentioned this pull request Jan 21, 2023
Closed
3 tasks
harveyyue pushed a commit to harveyyue/seatunnel that referenced this pull request Feb 7, 2023
@lvshaokang @harveyyue
[Bug][Connectors] Text And Json WriteStrategy lost the sinkColumnsInd…
f87dbef 
…exInRow (apache#3863)

* [Bug][Connectors] Text And Json WriteStrategy lost the sinkColumnsIndexInRow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 left review comments

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@TaoZex TaoZex TaoZex approved these changes

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lvshaokang @hailin0 @EricJoy2048 @TaoZex @TyrantLucifer