Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Connector-V2][MongoDB] Refactor MongoDB connector e2e test … #3819

Merged
merged 27 commits into from
Jan 16, 2023
Merged

[Improve][Connector-V2][MongoDB] Refactor MongoDB connector e2e test … #3819

merged 27 commits into from
Jan 16, 2023

Conversation

MonsterChenzhuo
Copy link
Contributor

@MonsterChenzhuo MonsterChenzhuo commented Dec 28, 2022 •
edited
Loading

Purpose of this pull request

close #3607

Check list

ashulin
ashulin reviewed Dec 28, 2022
View reviewed changes
Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove connector-mongodb-spark-e2e and connector-mongodb-flink-e2e module together?

@MonsterChenzhuo
Copy link
Contributor Author

Can you remove connector-mongodb-spark-e2e and connector-mongodb-flink-e2e module together?

@ashulin Thanks for your review,I have made the changes.

TyrantLucifer
TyrantLucifer previously approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TyrantLucifer
Copy link
Member

cc @ashulin @EricJoy2048 @hailin0

TaoZex
TaoZex previously approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Hisoka-X
Copy link
Member

Please check the data already write into mongoDB

@TyrantLucifer
Copy link
Member

Please check the data already write into mongoDB

Assert sink maybe a best choice.

@MonsterChenzhuo
Copy link
Contributor Author

@Hisoka-X Thanks for your review,I have made the changes.

TaoZex
TaoZex approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@TyrantLucifer TyrantLucifer merged commit df89459 into apache:dev Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashulin ashulin ashulin left review comments

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@TaoZex TaoZex TaoZex approved these changes

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][Connector-V2][MongoDB] Refactor MongoDB connector e2e test cases
5 participants
@MonsterChenzhuo @TyrantLucifer @Hisoka-X @ashulin @TaoZex