[Feature][SeaTunnel Engine] Add test to test stream job recover when all cluster node done and restart #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all cluster node done and restart
EricJoy2048
reviewed
Nov 24, 2022
| node3 = SeaTunnelServerStarter.createHazelcastInstance( | ||
| TestUtils.getClusterName(testClusterName)); | ||
|
|
||
| Thread.sleep(360000); |
There was a problem hiding this comment.
Why sleep 360000? I think we can wait all nodes added to cluster here.
There was a problem hiding this comment.
I have modified the code, but I cannot pass the CI. Is the code I modified wrong?
There was a problem hiding this comment.
I have modified the code, but I cannot pass the CI. Is the code I modified wrong?
Please wait #3418 merge. And then you need config to enable IMap storage for this test case.
There was a problem hiding this comment.
Thanks for your advice.
liugddx
approved these changes
Dec 7, 2022
EricJoy2048
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
#3430
Add test to test stream job recover when all cluster node done and restart
Check list
New License Guide