Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2][Lemlist]Add Lemlist source connector #3346

Merged
merged 15 commits into from
Nov 16, 2022

Conversation

TaoZex
Copy link
Contributor

@TaoZex TaoZex commented Nov 9, 2022

Purpose of this pull request

1.Create a common authentication method for SaaS,ther authentication methods will continue to be added later.

2.Add Lemlist source connector

config :
2da4ed17ac6e832fe432227dffc23ab

Without using fields:
686fc631cbec57a870d5cf2717fbca1

using fields:
33b492c185edd1fc6a3959448ac496e

Check list

@hailin0
Copy link
Member

hailin0 commented Nov 9, 2022

Thanks, can you help add the e2e test

reference
#3340

@TaoZex TaoZex closed this Nov 9, 2022
@TaoZex TaoZex reopened this Nov 9, 2022
Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add Lemlist source to plugin-mapping.properties

@TaoZex
Copy link
Contributor Author

TaoZex commented Nov 10, 2022

You need to add Lemlist source to plugin-mapping.properties

Thank you so much for your help.

@EricJoy2048
Copy link
Member

Please add e2e test reference #3340

@TaoZex
Copy link
Contributor Author

TaoZex commented Nov 12, 2022

Please add e2e test reference #3340

Thanks. I have added e2e test.

@TaoZex
Copy link
Contributor Author

TaoZex commented Nov 14, 2022

Thanks, can you help add the e2e test

reference #3340

Thanks. I have added e2e test.PTAL.

@TaoZex TaoZex closed this Nov 15, 2022
@TaoZex TaoZex reopened this Nov 15, 2022
@TaoZex TaoZex closed this Nov 15, 2022
@TaoZex TaoZex reopened this Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants