Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8336] Adjust the default value of ackMessageThreadPoolNums to 16 to prevent performance bottlenecks during high traffic #8337

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

RongtongJin
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8336

Brief Description

Adjust the default value of ackMessageThreadPoolNums to 16 to prevent performance bottlenecks during high traffic

How Did You Test This Change?

… performance bottlenecks during high traffic.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.15%. Comparing base (b31e0ce) to head (fc947ff).

Files Patch % Lines
...n/java/org/apache/rocketmq/store/ConsumeQueue.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8337      +/-   ##
=============================================
- Coverage      43.20%   43.15%   -0.05%     
+ Complexity     10524    10511      -13     
=============================================
  Files           1274     1274              
  Lines          88940    88940              
  Branches       11434    11434              
=============================================
- Hits           38428    38384      -44     
- Misses         45808    45840      +32     
- Partials        4704     4716      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShannonDing ShannonDing merged commit 3aa5d19 into apache:develop Jul 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] The default value of ackMessageThreadPoolNums is too small
7 participants