[ISSUE #8265] Implement Batch Creation of Topics in RocketMQ Admin #8267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizhimins
changed the title
RongtongJin
approved these changes
Jun 7, 2024
fuyou001
approved these changes
Jun 7, 2024
absolute8511
reviewed
Aug 8, 2024
| LOGGER.info("Broker receive request to update or create topic={}, but topicConfig has no changes , so idempotent, caller address={}", | ||
| topic, RemotingHelper.parseChannelRemoteAddr(ctx.channel())); | ||
| response.setCode(ResponseCode.SUCCESS); | ||
| return response; |
There was a problem hiding this comment.
we should continue here instead return, otherwise we will left the other topics uncreated after return success.
absolute8511
reviewed
Aug 8, 2024
| String topic = topicConfig.getTopicName(); | ||
| TopicValidator.ValidateTopicResult result = TopicValidator.validateTopic(topic); | ||
| if (!result.isValid()) { | ||
| response.setCode(ResponseCode.SYSTEM_ERROR); |
There was a problem hiding this comment.
SYSTEM_ERROR has been used in many different server error cases, maybe we should add some more code to indicate the client error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8265
Brief Description
How Did You Test This Change?