Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 8230]fix the acl for NotifyClientTerminationRequest because group can be null #8231

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

dingshuangxi888
Copy link
Contributor

…ull.

Which Issue(s) This PR Fixes

Fixes #8230

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 42.88%. Comparing base (89c1509) to head (30127b8).
Report is 21 commits behind head on develop.

Files Patch % Lines
...apache/rocketmq/acl/plain/PlainAccessResource.java 0.00% 2 Missing ⚠️
...on/builder/DefaultAuthorizationContextBuilder.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8231      +/-   ##
=============================================
- Coverage      42.93%   42.88%   -0.05%     
+ Complexity     10387    10369      -18     
=============================================
  Files           1270     1270              
  Lines          88693    88726      +33     
  Branches       11401    11408       +7     
=============================================
- Hits           38079    38053      -26     
- Misses         45925    45966      +41     
- Partials        4689     4707      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma merged commit 7145964 into apache:develop Jun 4, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] fix the acl for NotifyClientTerminationRequest because group can be null.
5 participants