-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #8046] Fix authentication context build for no extFields #8102
[ISSUE #8046] Fix authentication context build for no extFields #8102
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8102 +/- ##
==========================================
Coverage 42.86% 42.86%
- Complexity 10360 10362 +2
==========================================
Files 1270 1270
Lines 88690 88692 +2
Branches 11399 11400 +1
==========================================
+ Hits 38017 38020 +3
+ Misses 45976 45973 -3
- Partials 4697 4699 +2 ☔ View full report in Codecov by Sentry. |
If the client sets ak/sk, then all request headers will have ak/sk information, including heartbeats.
|
The old client may has no ReqeustHeader, such as Heartbeat api, if the ak/sk is not set, the extFields will be null and it will get NPE error. |
OK |
@dingshuangxi888 Some unit-tests maybe need to be resolved. |
Which Issue(s) This PR Fixes
Fixes #8046
Brief Description
Fix authentication context build for no extFields
How Did You Test This Change?
start producer/consumer without ak/sk