-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #8090] Optimize isSetEqual for DefaultLitePullConsumerImpl #8091
[ISSUE #8090] Optimize isSetEqual for DefaultLitePullConsumerImpl #8091
Conversation
….fix a typo in MQAdminImpl
/** | ||
* @author Willhow | ||
* @since 2024/5/3 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Author information needs to be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
作者信息需要删除
already removed. Also revised code style and added license comments
Error: /home/runner/work/rocketmq/rocketmq/client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java:1: Line does not match expected header line of '/*'. [RegexpHeader] |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8091 +/- ##
=============================================
- Coverage 42.88% 42.84% -0.05%
- Complexity 10348 10350 +2
=============================================
Files 1270 1270
Lines 88673 88680 +7
Branches 11398 11397 -1
=============================================
- Hits 38029 37994 -35
- Misses 45950 45989 +39
- Partials 4694 4697 +3 ☔ View full report in Codecov by Sentry. |
合并一下 develop 重新提交一下,develop 有一些单测的修复 |
merge develop了 |
Fixes #8090
How Did You Test This Change?
添加了单元测试验证isSetEqual方法是否符合预期