Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8095] Fix some flaky tests on Mac's workflow #8083

Merged
merged 10 commits into from
May 6, 2024

Conversation

RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Apr 30, 2024

Which Issue(s) This PR Fixes

Fixes #8095

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.80%. Comparing base (af43a3e) to head (2f59e3b).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8083      +/-   ##
=============================================
- Coverage      42.87%   42.80%   -0.08%     
+ Complexity     10360    10344      -16     
=============================================
  Files           1270     1270              
  Lines          88681    88681              
  Branches       11397    11397              
=============================================
- Hits           38025    37957      -68     
- Misses         45964    46028      +64     
- Partials        4692     4696       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin changed the title Fix the flaky test of testRenewExceedMaxRenewTimes Fix some flaky tests Apr 30, 2024
lizhimins
lizhimins previously approved these changes May 5, 2024
@RongtongJin RongtongJin changed the title Fix some flaky tests [ISSUE #8095] Fix some flaky tests onMac's pipeline May 6, 2024
@RongtongJin RongtongJin changed the title [ISSUE #8095] Fix some flaky tests onMac's pipeline [ISSUE #8095] Fix some flaky tests on Mac's workflow May 6, 2024
@lizhimins
Copy link
Member

lizhimins commented May 6, 2024

Temporarily ignore some unstable use cases.

@lizhimins lizhimins merged commit ac59c03 into apache:develop May 6, 2024
10 checks passed
dingshuangxi888 pushed a commit to dingshuangxi888/rocketmq that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Some tests often fail on Mac's pipeline
4 participants