[ISSUE #8076] Fix correct min cq offset when delete tiered storage CommitLog #8082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8082 +/- ##
=============================================
- Coverage 42.82% 42.81% -0.02%
+ Complexity 10347 10342 -5
=============================================
Files 1270 1270
Lines 88681 88689 +8
Branches 11397 11398 +1
=============================================
- Hits 37980 37970 -10
- Misses 46006 46020 +14
- Partials 4695 4699 +4 ☔ View full report in Codecov by Sentry. |
lollipopjin
reviewed
May 6, 2024
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/FlatCommitLogFile.java
Show resolved
Hide resolved
dingshuangxi888
pushed a commit
to dingshuangxi888/rocketmq
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mmitLog
Which Issue(s) This PR Fixes
Fixes #8076
Brief Description
How Did You Test This Change?