Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7836] flush_behind_bytes wrong in transientStorePoolEnable not enable #7957

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented Mar 22, 2024

when transientStorePoolEnable not enable, we should not add commit bytes

Which Issue(s) This PR Fixes

Fixes #7836

Brief Description

How Did You Test This Change?

@leizhiyuan leizhiyuan changed the title [ISSUE #7836]rocketmq_storage_flush_behind_bytes wrong when transientStor… [ISSUE #7836] flush_behind_bytes wrong in transientStorePoolEnable not enable Mar 22, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 42.82%. Comparing base (f2dd5b0) to head (7f0c4cf).

Files Patch % Lines
...org/apache/rocketmq/store/DefaultMessageStore.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7957      +/-   ##
=============================================
- Coverage      42.85%   42.82%   -0.03%     
+ Complexity     10355    10349       -6     
=============================================
  Files           1270     1270              
  Lines          88594    88596       +2     
  Branches       11393    11393              
=============================================
- Hits           37965    37941      -24     
- Misses         45952    45979      +27     
+ Partials        4677     4676       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit 27d8375 into apache:develop Mar 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] metrics rocketmq_storage_flush_behind_bytes maybe wrong
4 participants