Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7932] Rectify the modifier order in namesrv #7921

Merged
merged 1 commit into from
Mar 16, 2024
Merged

[ISSUE #7932] Rectify the modifier order in namesrv #7921

merged 1 commit into from
Mar 16, 2024

Conversation

oopooa
Copy link
Contributor

@oopooa oopooa commented Mar 14, 2024

Which Issue(s) This PR Fixes

Fixes #7932

Brief Description

Adhere to Java's modifier order specification.

How Did You Test This Change?

Only modifier order changed.

@RongtongJin
Copy link
Contributor

@oopooa It would be better to create an issue associated with the pull request.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.94%. Comparing base (3c27bfe) to head (575387b).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7921      +/-   ##
=============================================
+ Coverage      42.92%   42.94%   +0.02%     
- Complexity      9910     9920      +10     
=============================================
  Files           1190     1190              
  Lines          86042    86042              
  Branches       11081    11081              
=============================================
+ Hits           36930    36953      +23     
+ Misses         44537    44520      -17     
+ Partials        4575     4569       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oopooa
Copy link
Contributor Author

oopooa commented Mar 15, 2024

@RongtongJin The issue link has been added.

@RongtongJin RongtongJin changed the title Rectify the modifier order in namesrv [ISSUE #7932] Rectify the modifier order in namesrv Mar 16, 2024
@RongtongJin RongtongJin merged commit a32eca0 into apache:develop Mar 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Inconsistent field modifier order.
3 participants