[#ISSUE 7909] Fix send retry message permission check #7917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7917 +/- ##
=============================================
- Coverage 42.89% 42.88% -0.02%
Complexity 9909 9909
=============================================
Files 1190 1190
Lines 86042 86038 -4
Branches 11081 11081
=============================================
- Hits 36912 36901 -11
- Misses 44559 44565 +6
- Partials 4571 4572 +1 ☔ View full report in Codecov by Sentry. |
leizhiyuan
approved these changes
Mar 19, 2024
HScarb
approved these changes
Mar 21, 2024
lizhimins
approved these changes
Apr 18, 2024
dingshuangxi888
pushed a commit
to dingshuangxi888/rocketmq
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7909
Brief Description
Require the SUB permission of retry topic,not the producer group.
How Did You Test This Change?
UT