-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #7914] Fix the issue that pop revive msg to retry topic may lose messages #7915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7915 +/- ##
=============================================
+ Coverage 42.89% 42.92% +0.02%
Complexity 9909 9909
=============================================
Files 1190 1190
Lines 86042 86039 -3
Branches 11081 11080 -1
=============================================
+ Hits 36912 36934 +22
+ Misses 44559 44520 -39
- Partials 4571 4585 +14 ☔ View full report in Codecov by Sentry. |
RongtongJin
changed the title
Fix pop
[ISSUE #7914] Fix the issue that pop revive msg to retry topic may lose messages
Mar 14, 2024
RongtongJin
approved these changes
Mar 18, 2024
lizhimins
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7914
Brief Description
Some messages were lost if we do not ack them.
How Did You Test This Change?