Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7914] Fix the issue that pop revive msg to retry topic may lose messages #7915

Merged
merged 40 commits into from
Mar 18, 2024

Conversation

fujian-zfj
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7914

Brief Description

Some messages were lost if we do not ack them.
image

How Did You Test This Change?

fujian-zfj and others added 30 commits November 30, 2021 20:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.92%. Comparing base (72bd03c) to head (bb2d312).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7915      +/-   ##
=============================================
+ Coverage      42.89%   42.92%   +0.02%     
  Complexity      9909     9909              
=============================================
  Files           1190     1190              
  Lines          86042    86039       -3     
  Branches       11081    11080       -1     
=============================================
+ Hits           36912    36934      +22     
+ Misses         44559    44520      -39     
- Partials        4571     4585      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin changed the title Fix pop [ISSUE #7914] Fix the issue that pop revive msg to retry topic may lose messages Mar 14, 2024
@RongtongJin RongtongJin merged commit 9b4f16a into apache:develop Mar 18, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] pop revive msg to retry topic may lose messages
4 participants