Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7878] Performance Improvement and Bug Fixes for the Tiered Storage Module #7899

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #7878

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 84.27720% with 211 lines in your changes are missing coverage. Please review.

Project coverage is 43.08%. Comparing base (333c545) to head (79278eb).
Report is 1 commits behind head on develop.

Files Patch % Lines
...etmq/tieredstore/core/MessageStoreFetcherImpl.java 77.92% 39 Missing and 12 partials ⚠️
...q/tieredstore/core/MessageStoreDispatcherImpl.java 70.54% 24 Missing and 19 partials ⚠️
...pache/rocketmq/tieredstore/TieredMessageStore.java 70.78% 9 Missing and 17 partials ⚠️
...che/rocketmq/tieredstore/file/FlatMessageFile.java 88.88% 7 Missing and 10 partials ⚠️
.../rocketmq/tieredstore/index/IndexStoreService.java 72.54% 7 Missing and 7 partials ⚠️
...tieredstore/metrics/TieredStoreMetricsManager.java 18.75% 13 Missing ⚠️
...ache/rocketmq/tieredstore/file/FlatAppendFile.java 91.33% 5 Missing and 6 partials ⚠️
...pache/rocketmq/tieredstore/file/FlatFileStore.java 85.71% 9 Missing and 2 partials ⚠️
...ocketmq/tieredstore/provider/PosixFileSegment.java 85.96% 4 Missing and 4 partials ⚠️
...pache/rocketmq/tieredstore/MessageStoreConfig.java 90.32% 3 Missing ⚠️
... and 8 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7899      +/-   ##
=============================================
+ Coverage      42.93%   43.08%   +0.15%     
+ Complexity      9909     9856      -53     
=============================================
  Files           1190     1184       -6     
  Lines          86042    85187     -855     
  Branches       11081    10978     -103     
=============================================
- Hits           36938    36703     -235     
+ Misses         44527    43997     -530     
+ Partials        4577     4487      -90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit 026a910 into apache:develop Mar 18, 2024
9 of 10 checks passed
dingshuangxi888 added a commit to dingshuangxi888/rocketmq that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Performance Improvement and Bug Fixes for the Tiered Storage Module
4 participants