Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7872] Fix Tiered Store Query Message Async return different view each time #7874

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

AYue-94
Copy link
Contributor

@AYue-94 AYue-94 commented Feb 29, 2024

…iew each time

Which Issue(s) This PR Fixes

Fixes #7872

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.87%. Comparing base (dde4fcc) to head (7bffbbd).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7874      +/-   ##
=============================================
+ Coverage      42.83%   42.87%   +0.03%     
- Complexity     10347    10354       +7     
=============================================
  Files           1270     1270              
  Lines          88617    88619       +2     
  Branches       11395    11395              
=============================================
+ Hits           37957    37991      +34     
+ Misses         45976    45947      -29     
+ Partials        4684     4681       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins self-requested a review February 29, 2024 12:51
@lizhimins
Copy link
Member

Hi, There are some design changes here. Please submit the modifications to class "MessageStoreFetcherImpl".

AYue-94 added 2 commits March 26, 2024 13:33
# Conflicts:
#	tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageFetcher.java
@lizhimins lizhimins changed the title [ISSUE #7872] Fix Tiered Store Query Message Async return different v… [ISSUE #7872] Fix Tiered Store Query Message Async return different view each time Mar 26, 2024
@lizhimins lizhimins merged commit d9c75ff into apache:develop Mar 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Tiered Store Query Message Async return different view each time
3 participants