-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #7848] Fix exception when pop messages with multiple LMQ indexes #7863
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7863 +/- ##
=============================================
- Coverage 42.85% 42.81% -0.04%
+ Complexity 10355 10346 -9
=============================================
Files 1270 1270
Lines 88677 88681 +4
Branches 11398 11397 -1
=============================================
- Hits 37999 37972 -27
- Misses 45990 46010 +20
- Partials 4688 4699 +11 ☔ View full report in Codecov by Sentry. |
DefaultMQPushConsumerTest failed, but it seems due to GitHub environment issues, need to rerun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@redlsz could you please re-run the CI tasks? |
Sure. |
https://github.com/apache/rocketmq/actions/runs/8750479357/job/24014103256?pr=7863 @HScarb Still failed. It seems to be related to the macos version. |
I fixed CI tasks, you can rebase on develop branch and force push to your branch to trigger CI tasks again |
ef6afa3
to
9cc9822
Compare
Which Issue(s) This PR Fixes
Fixes #7848
Brief Description
Parse property PROPERTY_INNER_MULTI_DISPATCH and property PROPERTY_INNER_MULTI_QUEUE_OFFSET.
How Did You Test This Change?
unit test