Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7848] Fix exception when pop messages with multiple LMQ indexes #7863

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

redlsz
Copy link
Contributor

@redlsz redlsz commented Feb 27, 2024

Which Issue(s) This PR Fixes

Fixes #7848

Brief Description

Parse property PROPERTY_INNER_MULTI_DISPATCH and property PROPERTY_INNER_MULTI_QUEUE_OFFSET.

How Did You Test This Change?

unit test

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.81%. Comparing base (04dddec) to head (9cc9822).

Files Patch % Lines
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7863      +/-   ##
=============================================
- Coverage      42.85%   42.81%   -0.04%     
+ Complexity     10355    10346       -9     
=============================================
  Files           1270     1270              
  Lines          88677    88681       +4     
  Branches       11398    11397       -1     
=============================================
- Hits           37999    37972      -27     
- Misses         45990    46010      +20     
- Partials        4688     4699      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leizhiyuan
Copy link
Contributor

DefaultMQPushConsumerTest failed, but it seems due to GitHub environment issues, need to rerun

Copy link
Contributor

@HScarb HScarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HScarb
Copy link
Contributor

HScarb commented Apr 18, 2024

@redlsz could you please re-run the CI tasks?

@redlsz
Copy link
Contributor Author

redlsz commented Apr 19, 2024

@redlsz could you please re-run the CI tasks?

Sure.

@redlsz
Copy link
Contributor Author

redlsz commented Apr 24, 2024

@redlsz could you please re-run the CI tasks?

https://github.com/apache/rocketmq/actions/runs/8750479357/job/24014103256?pr=7863
image

@HScarb Still failed. It seems to be related to the macos version.

@HScarb
Copy link
Contributor

HScarb commented Apr 29, 2024

@redlsz could you please re-run the CI tasks?

https://github.com/apache/rocketmq/actions/runs/8750479357/job/24014103256?pr=7863 image

@HScarb Still failed. It seems to be related to the macos version.

I fixed CI tasks, you can rebase on develop branch and force push to your branch to trigger CI tasks again

@redlsz redlsz force-pushed the bugfix/pop-lmq-exception branch from ef6afa3 to 9cc9822 Compare April 30, 2024 03:11
@caigy caigy merged commit af43a3e into apache:develop Apr 30, 2024
10 checks passed
dingshuangxi888 pushed a commit to dingshuangxi888/rocketmq that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Exception when pop messages with multiple LMQ indexes
7 participants