Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7803] Add try catch for lock and unlock #7804

Merged
merged 3 commits into from
Feb 4, 2024

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Jan 30, 2024

Which Issue(s) This PR Fixes

Fixes #7803

Brief Description

Add try catch for lock and unlock

How Did You Test This Change?

fuyou001
fuyou001 previously approved these changes Jan 30, 2024
Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (1784213) 43.31% compared to head (422f9bd) 43.01%.
Report is 9 commits behind head on develop.

Files Patch % Lines
...he/rocketmq/proxy/processor/ConsumerProcessor.java 42.55% 25 Missing and 2 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7804      +/-   ##
=============================================
- Coverage      43.31%   43.01%   -0.30%     
- Complexity      9886     9923      +37     
=============================================
  Files           1173     1190      +17     
  Lines          85047    85948     +901     
  Branches       11014    11074      +60     
=============================================
+ Hits           36836    36971     +135     
- Misses         43646    44406     +760     
- Partials        4565     4571       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lollipopjin lollipopjin merged commit 702bbd2 into apache:develop Feb 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add try catch for lock and unlock
5 participants