Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7466] Added fast failure in adminBrokerThreadPoolQueue (#7466) #7798

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

yp969803
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7466

Brief Description

Added fast failure in adminBrokerThreadPoolQueue

How Did You Test This Change?

mvn test

@yp969803
Copy link
Contributor Author

@weihubeats @RongtongJin can you verify this pr

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1242a58) 0.00% compared to head (606c113) 42.94%.
Report is 12 commits behind head on develop.

Files Patch % Lines
.../java/org/apache/rocketmq/common/BrokerConfig.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #7798       +/-   ##
==============================================
+ Coverage           0   42.94%   +42.94%     
- Complexity         0     9896     +9896     
==============================================
  Files              0     1190     +1190     
  Lines              0    85936    +85936     
  Branches           0    11070    +11070     
==============================================
+ Hits               0    36901    +36901     
- Misses             0    44460    +44460     
- Partials           0     4575     +4575     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guyinyou
Copy link
Contributor

consumerManagerThreadPoolQueue also need fast failure, could you please add it ?

@RongtongJin RongtongJin merged commit 568950b into apache:develop Jun 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Maybe adminBrokerThreadPoolQueue could also add fast failure
5 participants