Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7786] Optimize the execution logic of tool.sh in the JRE environment #7787

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

sevenleave
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7786

Brief Description

修复了在jre环境下,mqadmin命令执行时,会报错JAVA_HOME未设置的错误!详情和复现,可以见 #7786
报错信息:

readlink: missing operand
Try 'readlink --help' for more information.
dirname: missing operand
Try 'dirname --help' for more information.
dirname: missing operand
Try 'dirname --help' for more information.
ERROR: Please set the JAVA_HOME variable in your environment, We need java(x64)! !!

How Did You Test This Change?

测试结果,可以见 #7786

@RongtongJin RongtongJin changed the title fix: tools.sh脚本,把判断JAVA_HOME的逻辑提前 [ISSUE #7786] Optimize the execution logic of tool.sh in the JRE environment Jan 29, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d357bb) 43.29% compared to head (54e28b6) 43.27%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7787      +/-   ##
=============================================
- Coverage      43.29%   43.27%   -0.02%     
+ Complexity      9886     9878       -8     
=============================================
  Files           1173     1173              
  Lines          85049    85049              
  Branches       11015    11015              
=============================================
- Hits           36819    36804      -15     
- Misses         43658    43678      +20     
+ Partials        4572     4567       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit 1784213 into apache:develop Jan 29, 2024
9 of 10 checks passed
@jiangxuhui
Copy link

rocketmq 5.3.0. no useful. the bug is still here.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The find_java_home function of tools.sh reports an error in the JRE environment
4 participants