Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7768]Improve RouteInfoManager#registerTopic readability #7776

Closed
wants to merge 1 commit into from

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Jan 22, 2024

Which Issue(s) This PR Fixes

Fixes #7768

Brief Description

Improve RouteInfoManager#registerTopic readability

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6d75134) 43.21% compared to head (fde276f) 43.19%.

Files Patch % Lines
...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7776      +/-   ##
=============================================
- Coverage      43.21%   43.19%   -0.02%     
- Complexity      9859     9860       +1     
=============================================
  Files           1171     1171              
  Lines          85025    85016       -9     
  Branches       11015    11013       -2     
=============================================
- Hits           36744    36725      -19     
- Misses         43717    43733      +16     
+ Partials        4564     4558       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

@github-actions github-actions bot added the stale label Jan 22, 2025
Copy link

This PR was closed because it has been inactive for 3 days since being marked as stale.

@github-actions github-actions bot closed this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Improve RouteInfoManager#registerTopic readability
2 participants