-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #7560] [RIP-68] Support RocketMQ ACL 2.0 #7725
[ISSUE #7560] [RIP-68] Support RocketMQ ACL 2.0 #7725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 缓存部分,打开 cache 自带的 stats 统计能力并输出,性能影响很小,默认缓存大小是否合理?
- 能否快速找到问题用户或者资源?
- this.kvStore.flushWal(true); rocksdb 部分应该保证数据同步落盘。
- 鉴权降级和部分降级能力是否验证过。
- RequestHeaderRegistry.getInstance().initialize(); 这个地方能不能去单例,broker container 模式是否可以?
- if (this.authorizationMetadataManager != null) 这里 bug 了,shutdown 了两次。。。
- 请求失败时,错误日志过多,会打爆磁盘。
- RemotingCode 需要加前缀和别的请求区分。
- AbstractTransactionalMessageCheckListener.java 这里加个 topic 干啥用的?
- GrpcServerBuilder.java 鉴权 interceptors 和 global interceptors 的顺序是否正确?
|
It‘s better to have a clear roadmap like how to treat the old version acl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The old version acl will be removed soon, It is good idea to deprecated at enableAcl config. |
Are there any plans to reverse this ability into RocketMQ 4.x? |
There is no such plan at the moment, but you can implement it yourself. |
Which Issue(s) This PR Fixes
Fixes #7560
Brief Description
How Did You Test This Change?
broker config
proxy config
migration from acl v1