Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7543] only call a single type of retry topic in pop #7665

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Dec 15, 2023

Which Issue(s) This PR Fixes

Fixes #7543

Brief Description

only call a single type of retry topic in pop

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (a376fbc) 43.19% compared to head (6cc31ec) 43.17%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...rocketmq/broker/processor/PopMessageProcessor.java 16.66% 27 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7665      +/-   ##
=============================================
- Coverage      43.19%   43.17%   -0.03%     
+ Complexity      9812     9794      -18     
=============================================
  Files           1165     1165              
  Lines          84461    84477      +16     
  Branches       10964    10966       +2     
=============================================
- Hits           36482    36470      -12     
- Misses         43454    43475      +21     
- Partials        4525     4532       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drpmma drpmma merged commit 71a7a65 into apache:develop Dec 15, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Pop retry topic v2
4 participants