Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7091] Update the cd command in README #7096

Merged
merged 2 commits into from
Jul 30, 2023

Conversation

AayushSaini101
Copy link
Contributor

Issue-7091

Update the CD command in the ReadMe

Fixes #issue_id

Brief Description

Currently, the name of the file is incorrect that is mentioned in the readme needs to update with the correct file name.

@RongtongJin RongtongJin changed the title Update the cd command [ISSUE #7091] Update the cd command in README Jul 29, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #7096 (91df44f) into develop (d429bd7) will increase coverage by 0.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #7096      +/-   ##
=============================================
+ Coverage      42.73%   42.77%   +0.04%     
- Complexity      9295     9308      +13     
=============================================
  Files           1138     1138              
  Lines          81254    81254              
  Branches       10637    10637              
=============================================
+ Hits           34721    34759      +38     
+ Misses         42190    42154      -36     
+ Partials        4343     4341       -2     

see 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

RongtongJin
RongtongJin previously approved these changes Jul 29, 2023
README.md Outdated
@@ -63,7 +63,7 @@ $ unzip rocketmq-all-5.1.3-bin-release.zip

Prepare a terminal and change to the extracted `bin` directory:
```shell
$ cd rocketmq-all-5.1.3/bin
$ cd rocketmq-all-5.1.3-bin-release/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to remove the extra spaces at the beginning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RongtongJin Done in the last commit

@RongtongJin RongtongJin merged commit 8baa51e into apache:develop Jul 30, 2023
hirovcz pushed a commit to hirovcz/rocketmq that referenced this pull request Jul 30, 2023
* Update the cd command

* Removed extra space

---------

Co-authored-by: Aayush <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants