Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6106] Optimize getQueueIdByBroker naming ambiguity #6109

Merged
merged 10 commits into from
Feb 27, 2023

Conversation

socutes
Copy link
Contributor

@socutes socutes commented Feb 18, 2023

close #6106

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Merging #6109 (0dfdce6) into develop (7cfffe7) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #6109      +/-   ##
=============================================
+ Coverage      43.18%   43.19%   +0.01%     
- Complexity      8852     8854       +2     
=============================================
  Files           1094     1094              
  Lines          77153    77153              
  Branches       10063    10063              
=============================================
+ Hits           33321    33329       +8     
+ Misses         39665    39663       -2     
+ Partials        4167     4161       -6     
Impacted Files Coverage Δ
...ocketmq/client/impl/producer/TopicPublishInfo.java 64.10% <ø> (ø)
...pache/rocketmq/client/latency/MQFaultStrategy.java 18.18% <0.00%> (ø)
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 80.35% <0.00%> (-5.36%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 58.97% <0.00%> (-2.57%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 60.43% <0.00%> (-2.20%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 58.11% <0.00%> (-1.71%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-0.90%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 84.13% <0.00%> (-0.49%) ⬇️
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 68.17% <0.00%> (-0.47%) ⬇️
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@socutes
Copy link
Contributor Author

socutes commented Feb 19, 2023

@zhouxinyu PTAL

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouxinyu zhouxinyu merged commit 2f93cbe into apache:develop Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize getQueueIdByBroker naming ambiguity
5 participants