Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5986] optimize the BrokerOuterAPITest class code #5988

Merged
merged 1 commit into from
Feb 6, 2023
Merged

[ISSUE #5986] optimize the BrokerOuterAPITest class code #5988

merged 1 commit into from
Feb 6, 2023

Conversation

hardyfish
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

close #5986

Brief changelog

optimize the BrokerOuterAPITest class code

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #5988 (9754988) into develop (5b64ffc) will increase coverage by 0.97%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #5988      +/-   ##
=============================================
+ Coverage      42.43%   43.40%   +0.97%     
- Complexity      8277     8825     +548     
=============================================
  Files           1066     1090      +24     
  Lines          73671    76611    +2940     
  Branches        9630    10003     +373     
=============================================
+ Hits           31261    33255    +1994     
- Misses         38460    39200     +740     
- Partials        3950     4156     +206     
Impacted Files Coverage Δ
.../main/java/org/apache/rocketmq/common/UtilAll.java 35.91% <0.00%> (-0.62%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 58.46% <0.00%> (-3.08%) ⬇️
...a/org/apache/rocketmq/broker/BrokerController.java 43.25% <0.00%> (-2.90%) ⬇️
...pache/rocketmq/remoting/common/RemotingHelper.java 15.38% <0.00%> (-2.31%) ⬇️
...ache/rocketmq/store/queue/QueueOffsetAssigner.java 81.08% <0.00%> (-2.26%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 47.41% <0.00%> (-1.63%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) ⬇️
...c/main/java/org/apache/rocketmq/common/MixAll.java 41.44% <0.00%> (-1.29%) ⬇️
...apache/rocketmq/store/ha/GroupTransferService.java 92.30% <0.00%> (-1.29%) ⬇️
...q/controller/impl/manager/ReplicasInfoManager.java 61.07% <0.00%> (-0.89%) ⬇️
... and 72 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Oliverwqcwrw Oliverwqcwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hardyfish , Thanks for your contribution :-)

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@RongtongJin RongtongJin merged commit da531ef into apache:develop Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimize the test class code
5 participants