Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix pop orderly commit offset when NO_MATCHED_MESSAGE #8268

Closed
3 tasks done
drpmma opened this issue Jun 6, 2024 · 0 comments · Fixed by #8270
Closed
3 tasks done

[Bug] Fix pop orderly commit offset when NO_MATCHED_MESSAGE #8268

drpmma opened this issue Jun 6, 2024 · 0 comments · Fixed by #8270

Comments

@drpmma
Copy link
Contributor

drpmma commented Jun 6, 2024

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Not related

RocketMQ version

5.2.0

JDK Version

No response

Describe the Bug

When pop orderly returns NO_MATCHED_MESSAGE, it will invoke popBufferMergeService.addCkMock which is an async offset commit behavior leading to potential repeat offset.

Steps to Reproduce

Pop orderly with NO_MATCHED_MESSAGE, then pop message successfully.

What Did You Expect to See?

Repeat offset or repeat message consumption

What Did You See Instead?

No repeat

Additional Context

No response

@drpmma drpmma changed the title [Bug] Fix pop orderly offset [Bug] Fix pop orderly offset repeat Jun 6, 2024
@drpmma drpmma changed the title [Bug] Fix pop orderly offset repeat [Bug] Fix pop orderly commit offset when NO_MATCHED_MESSAGE Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant