Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Rpchook is still executed when remotingServer calls invoke #7833

Closed
1 task done
guyinyou opened this issue Feb 19, 2024 · 0 comments · Fixed by #7834
Closed
1 task done

[Enhancement] Rpchook is still executed when remotingServer calls invoke #7833

guyinyou opened this issue Feb 19, 2024 · 0 comments · Fixed by #7834

Comments

@guyinyou
Copy link
Contributor

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

rpchook is still executed when remotingServer calls invoke

Motivation

Theoretically, rpchook needs to be executed only when remotingClient calls invoke.

Describe the Solution You'd Like

Remove the rpchook call in org.apache.rocketmq.remoting.netty.NettyRemotingAbstract#invokeImpl and move it to remotingClient

Describe Alternatives You've Considered

none

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant