Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Optimization Method Name #7313

Closed
1 task done
CLFutureX opened this issue Sep 6, 2023 · 1 comment · Fixed by #7420
Closed
1 task done

[Enhancement] Optimization Method Name #7313

CLFutureX opened this issue Sep 6, 2023 · 1 comment · Fixed by #7420
Labels
type/enhancement

Comments

@CLFutureX
Copy link
Contributor

CLFutureX commented Sep 6, 2023 •
edited
Loading

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

path: org.apache.rocketmq.tieredstore.provider.TieredStoreTopicBlackListFilter

The method addTopicToWhiteList of this TieredStoreTopicBlackListFilter class should be renamed to addTopicToBlackList
image

Motivation

I found that the method name does not match the actual logic of the method

Describe the Solution You'd Like

Modify Method Name

Describe Alternatives You've Considered

Modify Method Name

Additional Context

No response
@CLFutureX CLFutureX mentioned this issue Sep 6, 2023
Closed
@shriVATSA54
Copy link
Contributor

shriVATSA54 commented Sep 30, 2023 •
edited
Loading

Hii
I want to work on this.
This is my first issue working on, I wanna give a try.

@shriVATSA54 shriVATSA54 mentioned this issue Oct 1, 2023
Merged
RongtongJin pushed a commit that referenced this issue Oct 7, 2023
@shriVATSA54
[ISSUE 7313] Enhancement Optimization Method name (#7420)
c36bb78 
* Enhancment/method_name/#7313/

* Enhancment/method_name/#7313/

* Enhancment/method_name/#7313/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE 7313] Enhancement Optimization Method name
2 participants
@CLFutureX @shriVATSA54