Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs): send heart beats every 10 seconds #677

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

fengmk2
Copy link
Contributor

@fengmk2 fengmk2 commented Jan 27, 2024

Which Issue(s) This PR Fixes

Fixes #676

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65b70ed) 55.89% compared to head (94e0ca8) 55.89%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #677   +/-   ##
=========================================
  Coverage     55.89%   55.89%           
  Complexity      668      668           
=========================================
  Files           259      259           
  Lines         15653    15653           
  Branches       3891     3891           
=========================================
  Hits           8750     8750           
  Misses         6650     6650           
  Partials        253      253           
Flag Coverage Δ
nodejs 86.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lizhanhui lizhanhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm this setting is consistent with other language bindings

@lizhanhui lizhanhui merged commit 0f38c07 into apache:master Jan 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The heart beats every 10 seconds, but the setting is 5 minutes
3 participants