Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #639 fix semantics of topicOfInterest #642

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

lizhanhui
Copy link
Contributor

Which Issue(s) This PR Fixes

fix #639

Brief Description

Fix semantics of topicOfInterest, which should be a reader

How Did You Test This Change?

Copy link
Member

@aaron-ai aaron-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

@lizhanhui lizhanhui merged commit c38f7d5 into apache:master Dec 1, 2023
17 checks passed
@lizhanhui lizhanhui deleted the fix_639 branch December 1, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] topicsOfInterest should pass a reference instead of a value
2 participants