RANGER-5130:DatSet policies fail to authorize when condition expression is present #528
+149
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
reviewed
Feb 6, 2025
security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java
Outdated
Show resolved
Hide resolved
…on is present --fix review comments
mneethiraj
reviewed
Feb 7, 2025
security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java
Outdated
Show resolved
Hide resolved
…ion is present -- review comments fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DatSet policies fail to authorize when condition expression is present. This happens if the DataSet / Shares is getting created via Grant API
What changes were proposed in this pull request?
Update the condition created via Grant API of GdsREST call to "validitySchedule" type. In this way the create condition will be evaluated by RangerValidityScheduleConditionEvaluator.
How was this patch tested?
Tested in local VM via invoking Grant API with policy condition of "conditions":[{"type":"validitySchedule","values":["{"startTime":"1970/01/01 00:00:00","endTime":"2025/03/08 00:35:28","timeZone":"UTC"}"]}]