-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch issue 8622: Remove python 2.7 #9268
Conversation
@nsalwan Thanks for your contribution! I saw it sill use python2.7 somewhere in the cpp tests:
@BewareMyPower Do you have some advice for that? |
@zymap Maybe the |
Yes, I think we need to remove all the python2 usage as possible as we can. |
The PythonLibs and Boost.Python dependency that are found by CMake are still Python2 related stuff.
The C++ tests CI environment is in image $ ls /usr/lib/x86_64-linux-gnu/libboost_python*.so
/usr/lib/x86_64-linux-gnu/libboost_python-py27.so /usr/lib/x86_64-linux-gnu/libboost_python.so
/usr/lib/x86_64-linux-gnu/libboost_python-py35.so
$ ls /usr/lib | grep python
python2.7
python3
python3.5 |
The pr had no activity for 30 days, mark with Stale label. |
@nsalwan:Thanks for your contribution. For this PR, do we need to update docs? |
Close it by #15376 |
Fixes #8622
Motivation
As per issue description : PIP-56 proposed we should upgrade our python version in the Docker image, we did that in the PR #7963.
But I still find some python2.7 usage in the pulsar repository.
We have fixed this issue.
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
getting rid of python 2.7
Modifications
Describe the modifications you've done.
Updated the CMake files.
Verifying this change
Yes, It does.
Documentation
It get rids of python 2.7 which is not supported by pulsar anyway.