-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Add docs for ProtobufNative Schema #9079
Conversation
@congbobo184 could u pls help review? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
site2/docs/schema-understand.md
Outdated
* to use different serialization/deserialization methods to handle data | ||
|Type|Description| | ||
---|---| | ||
`AvroBaseStructSchema`|Pulsar uses [Avro Specification](http://avro.apache.org/docs/current/spec.html) to declare the schema definition for `AvroBaseStructSchema`, which supports `AvroSchema`, `JsonSchema`, and `ProtobufSchema`. <br><br>This allows Pulsar:<br>- to use same tools to manage schema definitions<br>- to use different serialization or deserialization methods to handle data| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... to use the same tools...
site2/docs/schema-understand.md
Outdated
There are two methods to use `struct` schema: | ||
##### Usage | ||
|
||
Pulsar provides three methods to use the `struct` schema: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, it's 100% correct.
I suggest that we use "Pulsar provides the following methods to ...."
When people add more methods below, they usually forget to update the specific number.
@jennifer88huang thanks for your suggestions. I've incorporated your comments, PTAL. |
Add docs based on #8372 and update the green-highlighted parts.
![schema doc architecture](https://user-images.githubusercontent.com/50226895/103272642-5fa07380-49f8-11eb-8098-6eee7f930e93.png)