PIP-72: Introduce Pulsar Interface Taxonomy: Audience and Stability Classification #8530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* The checkstyle violations were introduced by two concurrent merges
sijie
added
the
type/feature
sijie
requested review from
rdhabalia,
jerrypeng,
hangc0276,
jiazhai and
codelipenghui
codelipenghui
approved these changes
Nov 12, 2020
|
/pulsarbot run-failure-checks |
eolivelli
requested changes
Nov 12, 2020
| @@ -22,9 +22,13 @@ | |||
|
|
|||
| import com.google.common.base.Predicate; | |||
| import com.google.common.collect.Range; | |||
| import org.apache.bookkeeper.common.annotation.InterfaceAudience; | |||
There was a problem hiding this comment.
why are you using "org.apache.bookkeeper.common" and not "org.apache.pulsar.common" here and in other files ?
it is a typo? or you did it for some reason ?
There was a problem hiding this comment.
managed-ledger already used bookkeeper annotations. I am keeping it consistent.
hangc0276
approved these changes
Nov 12, 2020
|
Good job. |
flowchartsman
pushed a commit
to flowchartsman/pulsar
that referenced
this pull request
Nov 17, 2020
…Classification (apache#8530) *Motivation* Introduce Pulsar Interface Taxonomy to provide guidance for developers and users to use Pulsar APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Introduce Pulsar Interface Taxonomy to provide guidance for developers and users to use Pulsar APIs.