[Issue 5454][pulsar-client-cpp]Fix cpp client schema version #5930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run cpp tests |
1 similar comment
|
run cpp tests |
|
run cpp tests |
|
run cpp tests |
|
run cpp tests |
sijie
approved these changes
Dec 25, 2019
run cpp tests |
|
run cpp tests |
2 similar comments
|
run cpp tests |
|
run cpp tests |
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…5930) Fixes apache#5454 ### Motivation The current CPP client cannot correctly obtain the schema version, resulting in an error in parsing with java client when sending data with schema using python client. Test code: ``` import pulsar import json from pulsar.schema import * class Test(Record): name = String() id = Integer() client = pulsar.Client('pulsar://localhost:6650'); producer = client.create_producer('test-producer-schema', schema=AvroSchema(Test)) producer.send(Test(name='Hello', id=1)) client.close() ``` ### Modifications * Add set schema version in msgmetadata ### Verifying this change Add check schema version in unit test SchemaTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5454
Motivation
The current CPP client cannot correctly obtain the schema version, resulting in an error in parsing with java client when sending data with schema using python client.
Test code:
Modifications
Verifying this change
Add check schema version in unit test SchemaTest